Skip to content

Conversation

@Ted-Jiang
Copy link
Member

Which issue does this PR close?

Add code Coverage tag 😊
image

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 22, 2022
@Ted-Jiang
Copy link
Member Author

@alamb After add code Coverage forget add this tag 😂
Seems higher than arrow-rs

@andygrove andygrove merged commit 1f67876 into apache:master Aug 22, 2022
@ursabot
Copy link

ursabot commented Aug 22, 2022

Benchmark runs are scheduled for baseline = 4838564 and contender = 1f67876. 1f67876 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Aug 31, 2022

Thanks @Ted-Jiang !

Seems higher than arrow-rs

I think at least one problem is that doctests don't count for coverage and arrow-rs has a bunch of doctests

@Ted-Jiang
Copy link
Member Author

Thanks @Ted-Jiang !

Seems higher than arrow-rs

I think at least one problem is that doctests don't count for coverage and arrow-rs has a bunch of doctests

@alamb Got it! will try to add this doctests to the report!

@alamb
Copy link
Contributor

alamb commented Sep 1, 2022

Thanks @Ted-Jiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants