Skip to content

Conversation

@kmitchener
Copy link
Contributor

@kmitchener kmitchener commented Sep 10, 2022

Which issue does this PR close?

Closes #3435.

Rationale for this change

TPC-H benchmarks were updated to use Decimal types, these tests should follow.

What changes are included in this PR?

In addition to change to Decimal type, I've ignored a test and entered an issue #3437 where it now fails.

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Sep 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3438 (b463451) into master (8b59b20) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   85.64%   85.60%   -0.04%     
==========================================
  Files         296      297       +1     
  Lines       54464    54473       +9     
==========================================
- Hits        46643    46633      -10     
- Misses       7821     7840      +19     
Impacted Files Coverage Δ
datafusion/core/tests/sql/explain_analyze.rs 83.87% <ø> (ø)
datafusion/core/tests/sql/predicates.rs 100.00% <ø> (ø)
datafusion/core/tests/sql/subqueries.rs 94.95% <ø> (+0.71%) ⬆️
datafusion/core/tests/sql/mod.rs 97.78% <100.00%> (+0.01%) ⬆️
datafusion/proto/src/to_proto.rs 52.00% <0.00%> (-0.54%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.02% <0.00%> (-0.34%) ⬇️
datafusion/sql/src/planner.rs 80.92% <0.00%> (-0.15%) ⬇️
datafusion/physical-expr/src/aggregate/count.rs 98.05% <0.00%> (ø)
datafusion/physical-expr/src/aggregate/average.rs 94.96% <0.00%> (ø)
...tafusion/physical-expr/src/aggregate/covariance.rs 98.70% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmitchener

@alamb alamb merged commit a8c1579 into apache:master Sep 12, 2022
@alamb
Copy link
Contributor

alamb commented Sep 12, 2022

Thanks again @kmitchener

@ursabot
Copy link

ursabot commented Sep 12, 2022

Benchmark runs are scheduled for baseline = 904b757 and contender = a8c1579. a8c1579 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kmitchener kmitchener deleted the 3435-update-tpch-test-schema branch September 12, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update TPCH test schemas to use Decimal128 from Float

5 participants