Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Sep 10, 2022

Which issue does this PR close?

N/A

Rationale for this change

Allow Ballista to support a wider range of queries

What changes are included in this PR?

Add all binary operators

Are there any user-facing changes?

@codecov-commenter
Copy link

Codecov Report

Merging #3441 (af50ffa) into master (73447b5) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3441      +/-   ##
==========================================
+ Coverage   85.49%   85.66%   +0.17%     
==========================================
  Files         296      297       +1     
  Lines       54331    54528     +197     
==========================================
+ Hits        46448    46714     +266     
+ Misses       7883     7814      -69     
Impacted Files Coverage Δ
datafusion/proto/src/from_proto.rs 39.60% <100.00%> (+5.33%) ⬆️
datafusion/proto/src/lib.rs 94.12% <100.00%> (+0.60%) ⬆️
datafusion/physical-expr/src/planner.rs 92.68% <0.00%> (-0.87%) ⬇️
datafusion/sql/src/planner.rs 80.92% <0.00%> (-0.76%) ⬇️
datafusion/optimizer/src/reduce_outer_join.rs 98.19% <0.00%> (-0.61%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.02% <0.00%> (-0.17%) ⬇️
datafusion/physical-expr/src/aggregate/count.rs 98.05% <0.00%> (ø)
datafusion/physical-expr/src/aggregate/average.rs 94.96% <0.00%> (ø)
...tafusion/physical-expr/src/aggregate/covariance.rs 98.70% <0.00%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ursabot
Copy link

ursabot commented Sep 11, 2022

Benchmark runs are scheduled for baseline = 1ec67da and contender = deea8c3. deea8c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Copy link
Contributor

@askoa askoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove BitwiseXor is not included in this PR which was introduced a day before in #3430.

Edit: Do you think I can include BitwiseXor while making changes for #3489 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants