Skip to content

Make the function from_proto_binary_op public#3490

Merged
yjshen merged 1 commit intoapache:masterfrom
askoa:binary-op
Sep 15, 2022
Merged

Make the function from_proto_binary_op public#3490
yjshen merged 1 commit intoapache:masterfrom
askoa:binary-op

Conversation

@askoa
Copy link
Copy Markdown
Contributor

@askoa askoa commented Sep 15, 2022

Which issue does this PR close?

Closes #3489

Are there any user-facing changes?

No

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3490 (7bf8aa5) into master (5f029cc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3490   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         299      299           
  Lines       55282    55282           
=======================================
  Hits        47408    47408           
  Misses       7874     7874           
Impacted Files Coverage Δ
datafusion/proto/src/from_proto.rs 39.86% <100.00%> (ø)
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.68% <0.00%> (ø)
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yjshen yjshen merged commit 84bee89 into apache:master Sep 15, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Sep 15, 2022

Benchmark runs are scheduled for baseline = f52d8af and contender = 84bee89. 84bee89 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@askoa askoa deleted the binary-op branch December 1, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make from_proto_binary_op public

5 participants