Skip to content

Bug fix: expr_visitor was not visiting aggregate filter expressions#3548

Merged
andygrove merged 2 commits intoapache:masterfrom
andygrove:aggr-filter-pushdown
Sep 20, 2022
Merged

Bug fix: expr_visitor was not visiting aggregate filter expressions#3548
andygrove merged 2 commits intoapache:masterfrom
andygrove:aggr-filter-pushdown

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented Sep 20, 2022

Which issue does this PR close?

Closes #3546

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

andygrove
andygrove commented Sep 20, 2022
View reviewed changes
Comment thread datafusion/optimizer/src/projection_push_down.rs
.build()?;

let expected = "Aggregate: groupBy=[[#test.a]], aggr=[[COUNT(#test.b), COUNT(#test.b) FILTER (WHERE #c > Int32(42)) AS count2]]\
\n TableScan: test projection=[a, b, c]";
Copy link
Copy Markdown
Member Author

@andygrove andygrove Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to the fix, the table scan projection was [a, b]

@andygrove
Copy link
Copy Markdown
Member Author

andygrove commented Sep 20, 2022

@alamb @tustvold please take a look when you can - this came up through Dask SQL testing

@andygrove
Copy link
Copy Markdown
Member Author

andygrove commented Sep 20, 2022

Thanks for the review @Dandandan! I am going to go ahead and merge since this seems uncontroversial and it unblocks a Dask SQL release

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Sep 20, 2022
@andygrove andygrove added the bug Something isn't working label Sep 20, 2022
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Sep 20, 2022

Thanks @andygrove

@andygrove andygrove merged commit 1261741 into apache:master Sep 20, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Sep 20, 2022

Benchmark runs are scheduled for baseline = 81b5794 and contender = 1261741. 1261741 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove deleted the aggr-filter-pushdown branch January 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@HaoYang670 HaoYang670 Awaiting requested review from HaoYang670

@liukun4515 liukun4515 Awaiting requested review from liukun4515

@Dandandan Dandandan Awaiting requested review from Dandandan

@viirya viirya Awaiting requested review from viirya

Assignees

No one assigned

Labels

bug Something isn't working logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aggregate filters do not get pushed down to table scan

4 participants

@andygrove @alamb @ursabot @Dandandan