Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Oct 7, 2022

Which issue does this PR close?

Closes #3743

Rationale for this change

The labeler CI check started failing on most PRs recently which makes it hard to see if a PR has a real problem or not

What changes are included in this PR?

Copy apache/arrow-rs#2844 (from @tustvold )

Which I think basically skips running the CI check if the user who submitted the PR doesn't have permissions to update labels on PRs.

Are there any user-facing changes?

I suspect the labeler will run less frequently.

It would be neat if someone could go and sort out how to get it working again -- this PR just treats the symptom not the underlying cause

@alamb alamb changed the title Try and fix labeler Do not run labeler CI check if it would fail due to permissions Oct 7, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 7, 2022

I am going to see if we can get some cleaner PRs

@alamb
Copy link
Contributor Author

alamb commented Oct 7, 2022

cc @andygrove

@alamb alamb merged commit db8dd19 into apache:master Oct 7, 2022
@ursabot
Copy link

ursabot commented Oct 7, 2022

Benchmark runs are scheduled for baseline = 0ab0e0f and contender = db8dd19. db8dd19 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/fix_labeler branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"labeler" PR check is broken

2 participants