Rename some split functions #3896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Marking this as a draft as I am backing out #3897 |
…shDown as possible Signed-off-by: yangjiang <yangjiang@ebay.com>
alamb
force-pushed
the
alamb/small_cleaups
branch
from
361326f to
21a7206
Compare
alamb
force-pushed
the
alamb/small_cleaups
branch
from
21a7206 to
0faf776
Compare
Contributor
Author
|
Closed in favor of Ted-Jiang#27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #3859 from @Ted-Jiang
Rationale for this change
This PR has some small changes to the API that I wanted to make on #3859 but didn't want to make @Ted-Jiang go back and forth again on
What changes are included in this PR?
split_binary_onwnedand restore thesplit_conjuctionfunction that splits binary expressions onANDAre there any user-facing changes?