Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Oct 19, 2022

Which issue does this PR close?

re #3858

Rationale for this change

I merged #3859 and I did not check it against master and it caused a logical merge conflict / plan regression

What changes are included in this PR?

This reverts commit ddfd052.

Are there any user-facing changes?

@alamb
Copy link
Contributor Author

alamb commented Oct 19, 2022

cc @Ted-Jiang

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Oct 19, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 19, 2022

I ran the tests locally and they all pass for me, so I am merging this one in without waiting for CI to finish to get master back green again

@alamb alamb merged commit 57e445a into apache:master Oct 19, 2022
@alamb alamb deleted the alamb/revert_rewrite branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant