Skip to content

Enable more benchmark verification tests #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 31, 2022
Merged

Enable more benchmark verification tests #4044

merged 6 commits into from
Oct 31, 2022

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Oct 31, 2022 •
edited
Loading

Which issue does this PR close?

Closes #4026
Closes #4025
Closes #4023

This replaces #4037

Rationale for this change

Enable all benchmark verification tests except for q6 (see #4024)

What changes are included in this PR?

Enable tests for q9, q11, q14, q17

Are there any user-facing changes?

@andygrove andygrove mentioned this pull request Oct 31, 2022
Closed
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Oct 31, 2022
@andygrove andygrove marked this pull request as ready for review October 31, 2022 15:25
@github-actions github-actions bot removed the logical-expr Logical plan and expressions label Oct 31, 2022
@andygrove andygrove merged commit bec3856 into apache:master Oct 31, 2022
@andygrove andygrove deleted the ci-enable-benchmarks branch October 31, 2022 18:16
@ursabot
Copy link

ursabot commented Oct 31, 2022

Benchmark runs are scheduled for baseline = 5cf090a and contender = bec3856. bec3856 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Oct 31, 2022

Thanks @andygrove

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@andygrove @viirya @Dandandan
Enable more benchmark verification tests (apache#4044)
7d0c667 
* Fix Decimal and Floating type coerce rule

* Enable more queries in benchmark verification tests

* update comparison_binary_numeric_coercion

* revert type coercin change in comparison_binary_numeric_coercion

* smaller tolerance

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@tustvold tustvold Awaiting requested review from tustvold

@Dandandan Dandandan Awaiting requested review from Dandandan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark q17 produces incorrect result benchmark q14 produces incorrect result benchmark q11 producing incorrect results

4 participants

@andygrove @ursabot @alamb @viirya