-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove alias in Union #4212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove alias in Union #4212
Conversation
|
@alamb @liukun4515 @andygrove @mingmwang , how do you think about it? |
CI failed due to network problem |
|
I'm OK with the change and remove the alias from Union. |
I have restarted this check |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find and nice cleanup @jackwener
!
|
Since this is effectively dead code I think it is safe to merge and if it turns out we need aliases on Union we can always add them back |
|
Benchmark runs are scheduled for baseline = 0dad3f3 and contender = 4dcf985. 4dcf985 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
Find in #4192 , I find alias should'n be in
Union.And it looks like part of the work has been done before,
alias in Unionwas never set.Aliastwo type:Union alias is
table-reference/subquery level, we already haveSubqueryAlias, so it's redundant and it will make conditon complex (we need consider more about union instead of just considerSubqueryAlias)What changes are included in this PR?
Remove alias in Union
Are these changes tested?
Are there any user-facing changes?