Skip to content

Fix nightly clippy failures #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix nightly clippy failures #4246

merged 2 commits into from
Nov 17, 2022

Conversation

@mvanschellebeeck
Copy link
Contributor

@mvanschellebeeck mvanschellebeeck commented Nov 16, 2022 •
edited
Loading

Closes #4245

Fixes a few nightly clippy issues

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Nov 16, 2022
@mvanschellebeeck mvanschellebeeck changed the title Fix clippy failres Fix clippy failures Nov 16, 2022
@mvanschellebeeck
Copy link
Contributor Author

mvanschellebeeck commented Nov 16, 2022

Turns out I was on nightly - closing

@mvanschellebeeck mvanschellebeeck deleted the mv/fix-clippy branch November 16, 2022 16:14
@mvanschellebeeck mvanschellebeeck restored the mv/fix-clippy branch November 16, 2022 18:33
@github-actions github-actions bot removed the core Core DataFusion crate label Nov 16, 2022
@mvanschellebeeck mvanschellebeeck changed the title Fix clippy failures Fix nightly clippy failures Nov 16, 2022
alamb
alamb approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvanschellebeeck

Reiterating why I think this is valuable: #4245 (comment)

@alamb alamb merged commit 929a175 into apache:master Nov 17, 2022
@ursabot
Copy link

ursabot commented Nov 17, 2022

Benchmark runs are scheduled for baseline = 7a81e9f and contender = 929a175. 929a175 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clippy failures

3 participants

@mvanschellebeeck @ursabot @alamb