Fix nightly clippy failures

datafusion/common/src/parsers.rs

@@ -111,7 +111,7 @@ pub fn parse_interval(leading_field: &str, value: &str) -> Result<ScalarValue> {
         let (diff_month, diff_days, diff_nanos) =
             calculate_from_part(interval_period_str.unwrap(), unit)?;
 
-        result_month += diff_month as i64;
+        result_month += diff_month;
 
         if result_month > (i32::MAX as i64) {
             return Err(DataFusionError::NotImplemented(format!(
@@ -120,7 +120,7 @@ pub fn parse_interval(leading_field: &str, value: &str) -> Result<ScalarValue> {
             )));
         }
 
-        result_days += diff_days as i64;
+        result_days += diff_days;
 
         if result_days > (i32::MAX as i64) {
             return Err(DataFusionError::NotImplemented(format!(

datafusion/physical-expr/src/aggregate/count_distinct.rs

@@ -182,8 +182,7 @@ impl Accumulator for DistinctCountAccumulator {
             .state_data_types
             .iter()
             .map(|state_data_type| {
-                let values = Box::new(Vec::new());
-                ScalarValue::new_list(Some(*values), state_data_type.clone())
+                ScalarValue::new_list(Some(Vec::new()), state_data_type.clone())
             })
             .collect::<Vec<_>>();
 

datafusion/physical-expr/src/aggregate/tdigest.rs

@@ -523,6 +523,7 @@ impl TDigest {
 
         let value = self.centroids[pos].mean()
             + ((rank - t) / self.centroids[pos].weight() - 0.5) * delta;
+
         Self::clamp(value, min, max)
     }
 
@@ -684,7 +685,7 @@ mod tests {
         let mut t = TDigest::new(10);
 
         for v in vals {
-            t = t.merge_unsorted_f64(vec![v as f64]);
+            t = t.merge_unsorted_f64(vec![v]);
         }
 
         assert_error_bounds!(t, quantile = 0.5, want = 1.0);

datafusion/physical-expr/src/expressions/binary.rs

@@ -2439,8 +2439,8 @@ mod tests {
             &[
                 Some(value), // 1.23
                 None,
-                Some((value - 1) as i128), // 1.22
-                Some(value + 1),           // 1.24
+                Some(value - 1), // 1.22
+                Some(value + 1), // 1.24
             ],
             10,
             2,
@@ -2561,10 +2561,10 @@ mod tests {
         let value: i128 = 123;
         let decimal_array = Arc::new(create_decimal_array(
             &[
-                Some(value as i128), // 1.23
+                Some(value), // 1.23
                 None,
-                Some(value - 1),           // 1.22
-                Some((value + 1) as i128), // 1.24
+                Some(value - 1), // 1.22
+                Some(value + 1), // 1.24
             ],
             10,
             2,
@@ -2682,8 +2682,8 @@ mod tests {
             &[
                 Some(value), // 1.23
                 None,
-                Some((value - 1) as i128), // 1.22
-                Some(value + 1),           // 1.24
+                Some(value - 1), // 1.22
+                Some(value + 1), // 1.24
             ],
             10,
             2,

datafusion/physical-expr/src/window/row_number.rs

@@ -65,7 +65,7 @@ impl BuiltInWindowFunctionExpr for RowNumber {
         &self,
         _batch: &RecordBatch,
     ) -> Result<Box<dyn PartitionEvaluator>> {
-        Ok(Box::new(NumRowsEvaluator::default()))
+        Ok(Box::<NumRowsEvaluator>::default())
     }
 }