Skip to content

Minor: remove unecessary clone() in planner #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Minor: remove unecessary clone() in planner #4249

merged 1 commit into from
Nov 17, 2022

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 16, 2022

Which issue does this PR close?

N/A

Rationale for this change

I noticed this while working on #4226

What changes are included in this PR?

remove some unecessary clone()

Are these changes tested?

yes by existing tests

Are there any user-facing changes?

no

@github-actions github-actions bot added the sql SQL Planner label Nov 16, 2022
@alamb alamb marked this pull request as draft November 17, 2022 01:42
@alamb
Copy link
Contributor Author

alamb commented Nov 17, 2022

Failing due to #4252

alamb
alamb commented Nov 17, 2022
View reviewed changes
datafusion/sql/src/planner.rs
SQLExpr::Nested(e) => self.sql_expr_to_logical_expr(*e, schema, ctes),

SQLExpr::Exists { subquery, negated } => self.parse_exists_subquery(&subquery, negated, schema, ctes),
SQLExpr::Exists { subquery, negated } => self.parse_exists_subquery(*subquery, negated, schema, ctes),
Copy link
Contributor Author

@alamb alamb Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it already has an owned copy -- there is no reason to pass in a reference to just clone it again

@alamb alamb marked this pull request as ready for review November 17, 2022 14:21
@andygrove andygrove merged commit 6f62870 into apache:master Nov 17, 2022
@ursabot
Copy link

ursabot commented Nov 17, 2022

Benchmark runs are scheduled for baseline = e18f7ba and contender = 6f62870. 6f62870 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/less_clone branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb @ursabot @andygrove