Skip to content

support cross_join in limit_push_down #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2022
Merged

support cross_join in limit_push_down #4257

merged 2 commits into from
Nov 18, 2022

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Nov 17, 2022

Which issue does this PR close?

Closes #4256.

Rationale for this change

What changes are included in this PR?

  • support limit-push-down with cross_join
  • add UT

Are these changes tested?

  • cross-join meet limit
  • cross-join meet limit-with-skip

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 17, 2022
waynexia
waynexia approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it's well tested 👍

@jackwener
Copy link
Member Author

jackwener commented Nov 18, 2022 •
edited
Loading

cc @liukun4515 @andygrove @alamb @HaoYang670

@jackwener jackwener mentioned this pull request Nov 18, 2022
Closed
liukun4515
liukun4515 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackwener

@liukun4515
Copy link
Contributor

liukun4515 commented Nov 18, 2022

I think we can also optimize limit - FULL Join pattern. @jackwener

@liukun4515 liukun4515 merged commit ff2f113 into apache:master Nov 18, 2022
@jackwener jackwener deleted the limit branch November 18, 2022 09:11
@ursabot
Copy link

ursabot commented Nov 18, 2022

Benchmark runs are scheduled for baseline = 822022d and contender = ff2f113. ff2f113 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515 liukun4515 mentioned this pull request Nov 18, 2022
Closed
@liukun4515
Copy link
Contributor

liukun4515 commented Nov 18, 2022

I think we can also optimize limit - FULL Join pattern. @jackwener

This thought has bug, will close this issue.

@alamb
Copy link
Contributor

alamb commented Nov 18, 2022

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liukun4515 liukun4515 liukun4515 approved these changes

@waynexia waynexia waynexia approved these changes

Assignees

No one assigned

Labels

optimizer Optimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Current limit_push_down can't support cross_join

5 participants

@jackwener @liukun4515 @ursabot @alamb @waynexia