Skip to content

Conversation

@crepererum
Copy link
Contributor

Which issue does this PR close?

None, but helps with #3940.

Rationale for this change

I need some helper methods to determine in-mem sizes of certain objects.

What changes are included in this PR?

Determine in-mem size of TDigest, ScalarValue, and Accumulator.

Are these changes tested?

-

Are there any user-facing changes?

⚠️ Breaking Change: Accumulator now requires fn size(&self) -> usize;!

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates labels Nov 23, 2022
@alamb alamb added the api change Changes the API exposed to users of the crate label Nov 23, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great -- thank you @crepererum

I had a few suggestions about docstrings but I don't think they are required (we could do them as a follow on PR).

For anyone following along, this is additional foundation to add proper memory accounting to DataFusion so its resource consumption can be constrained.

Note as this PR changes the API I plan to leave it open for at least 24 hours per https://arrow.apache.org/datafusion/contributor-guide/index.html#merging-prs

cc @Dandandan @andygrove @mingmwang @milenkovicm @tustvold and @yjshen

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@crepererum crepererum force-pushed the crepererum/issue3940c branch from 7dc14b4 to 0df6f40 Compare November 23, 2022 17:23
@alamb alamb merged commit e015043 into apache:master Nov 25, 2022
@ursabot
Copy link

ursabot commented Nov 25, 2022

Benchmark runs are scheduled for baseline = e1204a5 and contender = e015043. e015043 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants