Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 23, 2022

Which issue does this PR close?

N/A

Rationale for this change

I am debugging something wrong in one of the optimizer passes it wasn't immediately obvious to me from the logging that some passes didn't change the plan at all.

What changes are included in this PR?

Do not log the plan for optimizer passes that didn't make changes

Are these changes tested?

Not really

Are there any user-facing changes?

no

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 23, 2022
@alamb alamb requested review from Dandandan and andygrove November 26, 2022 12:53
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.
Printing a plan without changes is useless, this is a good improvement

@alamb alamb merged commit 323fbb4 into apache:master Nov 26, 2022
@ursabot
Copy link

ursabot commented Nov 26, 2022

Benchmark runs are scheduled for baseline = 27ae14a and contender = 323fbb4. 323fbb4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/improve_optimizer_logging branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants