remove redundant into_iter() calls
#527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
into_iter() calls
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=======================================
Coverage 76.03% 76.03%
=======================================
Files 157 157
Lines 26990 26990
=======================================
Hits 20521 20521
Misses 6469 6469
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 10, 2021
Contributor
|
I am surprised Clippy didn't complain about this ;) |
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* Remove libprotobuf as a build time dependency of Conda * Add substrait feature which enables building with substrait features * Add datafusion._internal/substrait to the pyproject.toml file so substrait will be built for pytests when using pip * Rename feature to just substrait * Add protoc since libprotobuf was removed from conda requirements file * Refactor substrait module being initialized as a function * Reintroduce libprotobuf as build dependency for conda build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
remove redundant
into_itercalls becauseVec<Result<_>>can automatically be transposed toResult<Vec<_>>- there is no need for additionalinto_itercallsWhat changes are included in this PR?
Are there any user-facing changes?