Skip to content

remove redundant into_iter() calls #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021
Merged

remove redundant into_iter() calls #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ballista/rust/core/src/serde/logical_plan/from_proto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,13 +914,11 @@ impl TryInto<Expr> for &protobuf::LogicalExprNode {
.partition_by
.iter()
.map(|e| e.try_into())
.into_iter()
.collect::<Result<Vec<_>, _>>()?;
let order_by = expr
.order_by
.iter()
.map(|e| e.try_into())
.into_iter()
.collect::<Result<Vec<_>, _>>()?;
let window_frame = expr
.window_frame
Expand Down
1 change: 0 additions & 1 deletion datafusion/src/physical_plan/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ fn window_aggregate_batch(
.collect::<Result<Vec<_>>>()?;
window_acc.scan_batch(batch.num_rows(), values)
})
.into_iter()
.collect::<Result<Vec<_>>>()
}

Expand Down
4 changes: 0 additions & 4 deletions datafusion/src/sql/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let select_exprs = select_exprs
.iter()
.map(|expr| rebase_expr(expr, &window_exprs, &plan))
.into_iter()
.collect::<Result<Vec<_>>>()?;
Ok((plan, select_exprs))
}
Expand Down Expand Up @@ -810,7 +809,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let order_by_rex = order_by
.iter()
.map(|e| self.order_by_to_sort_expr(e))
.into_iter()
.collect::<Result<Vec<_>>>()?;

LogicalPlanBuilder::from(&plan).sort(order_by_rex)?.build()
Expand Down Expand Up @@ -1126,13 +1124,11 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
.partition_by
.iter()
.map(|e| self.sql_expr_to_logical_expr(e))
.into_iter()
.collect::<Result<Vec<_>>>()?;
let order_by = window
.order_by
.iter()
.map(|e| self.order_by_to_sort_expr(e))
.into_iter()
.collect::<Result<Vec<_>>>()?;
let window_frame = window
.window_frame
Expand Down