Skip to content

Feature/merge batches removal #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dandandan merged 2 commits into from
Feb 16, 2023
Merged

Feature/merge batches removal #5300

Dandandan merged 2 commits into from
Feb 16, 2023

Conversation

@berkaysynnada
Copy link
Contributor

@berkaysynnada berkaysynnada commented Feb 16, 2023

Which issue does this PR close?

Closes #5297.

Rationale for this change

With the new concat_batches function in arrow::compute module. We no longer need to merge_batches function. It can be removed from codebase.

What changes are included in this PR?

merge_batches calls are replaced by concat_batches, and merge_batches is removed.

Are these changes tested?

Existing tests are enough, no need to write new tests.

Are there any user-facing changes?

No.

@berkaysynnada
Remove merge_batches function
e64ce1d 
merge_batches function is replaced by concat_batches function from arrow::compute
@berkaysynnada
Redundant merge_multiple_batches function is also removed
68a1120
@github-actions github-actions bot added the core Core DataFusion crate label Feb 16, 2023
@Dandandan Dandandan merged commit bee4285 into apache:main Feb 16, 2023
@ursabot
Copy link

ursabot commented Feb 16, 2023

Benchmark runs are scheduled for baseline = a10f3a0 and contender = bee4285. bee4285 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@berkaysynnada berkaysynnada deleted the feature/merge_batches_removal branch February 17, 2023 14:05
jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@berkaysynnada @jiangzhx
Feature/merge batches removal (apache#5300)
7ae66ce 
* Remove merge_batches function

merge_batches function is replaced by concat_batches function from arrow::compute

* Redundant merge_multiple_batches function is also removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dandandan Dandandan Dandandan approved these changes

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace merge_batches with concat_batches

4 participants

@berkaysynnada @ursabot @Dandandan @andygrove