-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Not equal predicate in physical_planning pruning #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 76.13% 76.15% +0.01%
==========================================
Files 156 156
Lines 27032 27047 +15
==========================================
+ Hits 20582 20597 +15
Misses 6450 6450
Continue to review full report at Codecov.
|
Dandandan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome -- thank you @jgoday !
apache#544)" This reverts commit 2568323.
* fix error message Co-authored-by: Andy Grove <andygrove73@gmail.com> --------- Co-authored-by: Andy Grove <andygrove73@gmail.com>
Which issue does this PR close?
Closes #420.
Rationale for this change
Pruning not equal predicates if the value is between min and max bounds.
What changes are included in this PR?
Are there any user-facing changes?
Change datafusion/src/physical_optimizer/pruning.rs build_predicate_expression to include Operator::NotEq
and define test case 'row_group_predicate_not_eq'