reuse code for now function expr creation #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
commented
Jun 13, 2021
| ctx_state.execution_props.query_execution_start_time, | ||
| )); | ||
|
|
||
| // TODO refactor code to not return here, but instead fall through below |
Member
Author
There was a problem hiding this comment.
This is the TODO item that gets addressed in this PR.
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 76.09% 76.08% -0.01%
==========================================
Files 156 156
Lines 27047 27040 -7
==========================================
- Hits 20581 20574 -7
Misses 6466 6466
Continue to review full report at Codecov.
|
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* disable xxhash64 by default * fix regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Move self contained change from #55 to separate PR to help reduce code review load.
What changes are included in this PR?
Reuse code for now function expr creation and fix TODO item in code.
Are there any user-facing changes?
no