hash float arrays using primitive usigned integer type #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate hash using u8 slices will be less efficient and breaks sepcialization in ahash. See tkaitchuck/aHash#93 for more details.
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 76.09% 76.10% +0.01%
==========================================
Files 156 156
Lines 27047 27057 +10
==========================================
+ Hits 20581 20593 +12
+ Misses 6466 6464 -2
Continue to review full report at Codecov.
|
Contributor
|
Thanks @houqp |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* Source release process proposal * small refinement * add more detail * fix * more detail * title * prettier * ASF header * address feedback
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
Bumps [async-trait](https://github.com/dtolnay/async-trait) from 0.1.74 to 0.1.77. - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](https://github.com/dtolnay/async-trait/commits) --- updated-dependencies: - dependency-name: async-trait dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #512.
Rationale for this change
Generate hash using u8 slices will be less efficient and breaks
sepcialization in ahash.
See tkaitchuck/aHash#93 for more details.
What changes are included in this PR?
Convert u8 slices back to u32 or u64 when calculating hashes for f32 and f64.
Are there any user-facing changes?
no