Qualified field resolution too strict #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@houqp Thank you for your comments. I have addressed them and pushed the new code. |
houqp
reviewed
Aug 3, 2021
houqp
approved these changes
Aug 3, 2021
Contributor
Author
|
thanks @houqp ! |
alamb
approved these changes
Aug 3, 2021
datafusion/src/sql/planner.rs
Outdated
|
|
||
| /// Rewrite aliases which are not-complete (e.g. ones that only include only table qualifier in a schema.table qualified relation) | ||
| fn rewrite_partial_qualifier(&self, expr: Expr, schema: &DFSchema) -> Expr { | ||
| match expr.clone() { |
Contributor
There was a problem hiding this comment.
given you are passing in expr here, I wonder if we could remove the call to clone and save a copy?
| let expr = self.sql_expr_to_logical_expr(sql, schema)?; | ||
| let mut expr = self.sql_expr_to_logical_expr(sql, schema)?; | ||
| self.validate_schema_satisfies_exprs(schema, &[expr.clone()])?; | ||
| expr = self.rewrite_partial_qualifier(expr, schema); |
Contributor
There was a problem hiding this comment.
I wonder if we should do the rewrite prior to calling validate_schema_satisfies_exprs?
Contributor
Author
|
@alamb I have taken your feedback and managed to remove the dfschema.rs changes entirely. I think this is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #809.
Rationale for this change
Due to the way the field qualification works a query this does not work as technically the field is qualified but the matching only works on complete matches between the field qualifier
personand the schema qualifierpublic.person.What changes are included in this PR?
This PR adds:
Are there any user-facing changes?
No, just more standard Postgres SQL will work.