RecordBatchReceiverStreamBuilder: don't stringify errors#9155
Merged
alamb merged 1 commit intoapache:mainfrom Feb 8, 2024
Merged
RecordBatchReceiverStreamBuilder: don't stringify errors#9155alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
The error is a DataFusionError already, so don't stringify it, just use it as-is.
tv42
force-pushed
the
RecordBatchReceiverStreamBuilder-return-error
branch
from
b3e0425 to
0484170
Compare
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error is a DataFusionError already, so don't stringify it, just use it as-is.
Are these changes tested?
cargo testpasses; the behavior doesn't seem to be covered by tests.Are there any user-facing changes?
Technically yes but I doubt anybody was matching on the error value. And if they were, this change is even more desirable!