Skip to content

RecordBatchReceiverStreamBuilder: don't stringify errors #9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Feb 8, 2024
Merged

RecordBatchReceiverStreamBuilder: don't stringify errors #9155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions datafusion/physical-plan/src/stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ use std::task::Poll;

use crate::displayable;
use arrow::{datatypes::SchemaRef, record_batch::RecordBatch};
use datafusion_common::internal_err;
use datafusion_common::DataFusionError;
use datafusion_common::Result;
use datafusion_common::{exec_err, internal_err};
use datafusion_execution::TaskContext;
use futures::stream::BoxStream;
use futures::{Future, Stream, StreamExt};
Expand Down Expand Up @@ -116,9 +116,7 @@ impl<O: Send + 'static> ReceiverStreamBuilder<O> {
// nothing to report
Ok(_) => continue,
// This means a blocking task error
Err(e) => {
return Some(exec_err!("Spawned Task error: {e}"));
}
Err(error) => return Some(Err(error)),
}
}
// This means a tokio task error, likely a panic
Expand Down