Add baseline metrics to SortPreservingMergeExec
#948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
SortPreservingMergeExec
alamb
changed the title
SortPreservingMergeExecSortPreservingMergeExec
alamb
changed the title
SortPreservingMergeExecSortPreservingMergeExec
alamb
force-pushed
the
alamb/annotate_merge_et_al
branch
from
418072c to
be9428a
Compare
alamb
force-pushed
the
alamb/annotate_merge_et_al
branch
from
a730a2f to
dcc601e
Compare
NGA-TRAN
approved these changes
Aug 26, 2021
| // Now, validate metrics | ||
| let metrics = merge.metrics().unwrap(); | ||
|
|
||
| assert!(metrics.output_rows().unwrap() > 0); |
Contributor
There was a problem hiding this comment.
I think we can verify the exact output_rows here, right?
Contributor
Author
There was a problem hiding this comment.
that is a good point. Will do
houqp
approved these changes
Aug 27, 2021
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Next part #866
Builds on #938 so review that first
Rationale for this change
We want basic understanding of where a plan's time is spent and in what operators. See #866 for more details
What changes are included in this PR?
SortPreservingMergeExecusing the API from Add BaselineMetrics, Timestamp metrics, add forCoalescePartitionsExec, rename output_time -> elapsed_compute #909Are there any user-facing changes?
More fields in
EXPLAIN ANALYZEare now filled out