Exclude .github directory from release tarball #9850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
added
the
development-process
phillipleblanc
approved these changes
Mar 29, 2024
alamb
approved these changes
Mar 29, 2024
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9843
Rationale for this change
We do not run the RAT check against the files under the hidden directory
.githubin CI, and some of these files are currently missing licenses (#9851).However, when we create the release tarball, we include these files in the tarball and then run the RAT check against them, and this currently fails.
What changes are included in this PR?
This PR updates
.gitattributesso that we no longer include the.githubfiles in the release tarball. There really is no need to include these files in a release.Are these changes tested?
I manually tested with the following command before and after making the change to
.gitattributesand confirmed that the modification was effective in excluding the.githubfiles from the tarball:Are there any user-facing changes?