Density sketch#363
Merged
Merged
Conversation
Update density sketch to use custom kernel, in both c++ and python
Density serialization
Pull Request Test Coverage Report for Build 4739860036
💛 - Coveralls |
Contributor
Author
|
Yup, fixed CMakeLists.txt files (main and python) as well as the python files to import all the relevant pieces. And reconciliation was to just take the changes from both. |
AlexanderSaydakov
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if we want to spend more time on characterization, but I believe the sketch itself is ready for inclusion in the library. The conflicts should just be reconciling the CMakeLists.txt files to play nicely with the count-min sketch.