Fix CpcWrapper throwing on empty sketches - #757
Merged
leerho merged 1 commit intoSep 2, 2026
Conversation
An empty CPC image carries none of the high preamble fields, but getEstimate() and the two bound methods read them regardless, so every empty sketch throws SketchesStateException. Empty now reports zero coupons and a zero HIP accumulator, matching what CpcSketch reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CpcWrapper.getEstimate(),getLowerBound()andgetUpperBound()throwSketchesStateExceptionfor any empty sketch, so the class can't be used by a callerwhose data may contain one.
An empty image carries none of the high preamble fields.
EMPTY_HIPsets the HIP flag, sogetEstimate()takes the HIP branch and asks forHIP_ACCUM;EMPTY_MERGEDtakes the ICONbranch and asks for
NUM_COUPONS. Neither field is present, so both throw.Empty now reports zero coupons and a zero HIP accumulator, matching
CpcSketch.Added
CpcWrapperEquivalenceTest, which checks the wrapper against a heapified sketch onestimate, both bounds and lgK, across every lgK, the coupon counts that drive the flavor
transitions, union results, and the three ways a sketch can be empty.