refactor: centralize seed hash validation - #183
Merged
Conversation
tisonkun
requested changes
Aug 5, 2026
tisonkun
left a comment
Member
There was a problem hiding this comment.
Different checks may return different error.
Perhaps a check_seed_hash(expect, actual, |expect, actual|...) help. I don't know.
Contributor
Author
|
Thanks — updated in 6b193ad. Validation after the change:
|
tisonkun
marked this pull request as ready for review
August 6, 2026 03:01
tisonkun
enabled auto-merge (squash)
August 6, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
What changed
check_seed_hashhelper that computes the expected hash once and preserves the existing invalid-data errorValidation
cargo x prepare-testdata— passed (645 cross-language snapshots prepared)cargo x test— passed-D warnings— passedcargo x lintreached and passed all repository/code checks above, but its final local-tool bootstrap could not installhawkeye 6.5.1with the repository's Rust 1.86 toolchain because current transitive crates require Rust 1.88+; no source/license finding was reported before that environment-only bootstrap failure.Risk and rollback
This is an internal refactor with no public API or serialized-format change. The main risk is an accidentally changed error kind/message; the helper retains
ErrorKind::InvalidDatathroughError::deserialand the prior message text. Reverting commit0d6570bfully rolls it back.AI assistance
OpenAI Codex assisted with implementation and validation. I reviewed the diff and test results.