Skip to content

feat: org plugin - #2461

Merged
klesh merged 16 commits into
apache:mainfrom
merico-ai:team-solution
Jul 15, 2022
Merged

feat: org plugin#2461
klesh merged 16 commits into
apache:mainfrom
merico-ai:team-solution

Conversation

@mindlesscloud

Copy link
Copy Markdown
Contributor

Summary

A new plugin org was created to fulfill the requirement of #2361

Does this close any open issues?

relate #2361

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@mindlesscloud
mindlesscloud force-pushed the team-solution branch 2 times, most recently from 4a35643 to 061c030 Compare July 13, 2022 16:40
Comment thread plugins/org/api/blueprint.go Outdated
"github.com/apache/incubator-devlake/plugins/helper"
)

func MakePipelinePlan(subtaskMetas []core.SubTaskMeta, connectionId uint64, scope []*core.BlueprintScopeV100) (core.PipelinePlan, error) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed. Only data-source plugins need to implement this for the new config-ui flow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will remove it

Comment thread plugins/org/api/user_account_mapping.go Outdated
// @Success 200
// @Failure 400 {object} shared.ApiBody "Bad Request"
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/org/accounts.csv [put]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/plugins/org/user_account_mapping.csv

Comment thread plugins/org/api/user_account_mapping.go Outdated
// @Success 200
// @Failure 400 {object} shared.ApiBody "Bad Request"
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/org/accounts.csv [get]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/plugins/org/user_account_mapping.csv

Comment thread plugins/org/tasks/user_account.go Outdated
if err != nil {
return err
}
err = db.Delete(&crossdomain.UserAccount{}, dal.Where("1=1"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't delete the existing relationship, but try to connect orphaned accounts to possible matched users

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem so...

@klesh klesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants