Skip to content

fix: do not pre-select active entity in create-mode#2799

Merged
klesh merged 2 commits into
apache:mainfrom
merico-ai:jc-2784-transformations-go-back
Aug 23, 2022
Merged

fix: do not pre-select active entity in create-mode#2799
klesh merged 2 commits into
apache:mainfrom
merico-ai:jc-2784-transformations-go-back

Conversation

@e2corporation
Copy link
Copy Markdown
Contributor

@e2corporation e2corporation commented Aug 23, 2022

Config-UI / Blueprints / Create Blueprint / Edit Transformation

  • Fix Do Not Pre-Select the Active Entity (Project/Board) for Blueprint Create Mode
  • Feature Add Tooltip & Spinner Indicator to Go Back Button

Description

This PR applies an adjustment to the Create Blueprint Workflow so that the first Active Project or Board is not automatically selected for editing. This is needed so that users can see the list of projects/boards to "edit" first. A Tooltip Indicator has also been added to the "Go Back" action so users are aware that they must complete editing before proceeding Next.

Does this close any open issues?

#2784

Screenshots

Screen Shot 2022-08-22 at 8 10 05 PM

@e2corporation e2corporation added this to the v0.13.0 milestone Aug 23, 2022
@e2corporation e2corporation self-assigned this Aug 23, 2022
@e2corporation e2corporation added pr-type/bug-fix This PR fixes a bug component/config-ui This issue or PR relates to config-ui labels Aug 23, 2022
@e2corporation e2corporation marked this pull request as ready for review August 23, 2022 03:15
@e2corporation e2corporation requested a review from klesh August 23, 2022 03:15
@e2corporation e2corporation force-pushed the jc-2784-transformations-go-back branch from d53e4ec to abfdca2 Compare August 23, 2022 12:56
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it should work. @yumengwang03 please try to improve the interaction furthermore in the future, thx.

@klesh klesh merged commit 3ec9589 into apache:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants