Skip to content

fix: do not pre-select active entity in create-mode #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 2 commits into from
Aug 23, 2022
Merged

fix: do not pre-select active entity in create-mode #2799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c977d8b
fix: do not pre-select active entity in create-mode
e2corporation Aug 23, 2022
abfdca2
feat: add tooltip and indicator to go back button
e2corporation Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions config-ui/src/components/blueprints/create-workflow/DataTransformations.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ import {
Elevation,
Card,
Colors,
Spinner,
Tooltip,
Position
} from '@blueprintjs/core'
import { Select } from '@blueprintjs/select'
import { integrationsData } from '@/data/integrations'
Expand Down Expand Up @@ -116,18 +119,18 @@ const DataTransformations = (props) => {
}, [entityList])

useEffect(() => {
console.log('>>>>> PROJECT / BOARD ENTITY SELECTED!', activeEntity)
switch (activeEntity?.type) {
case 'board':
addBoardTransformation(activeEntity?.entity)
// addProjectTransformation(null)
break
case 'project':
addProjectTransformation(activeEntity?.entity)
// addBoardTransformation(null)
break
if (useDropdownSelector) {
console.log('>>>>> PROJECT / BOARD ENTITY SELECTED!', activeEntity)
switch (activeEntity?.type) {
case 'board':
addBoardTransformation(activeEntity?.entity)
break
case 'project':
addProjectTransformation(activeEntity?.entity)
break
}
}
}, [activeEntity, addBoardTransformation, addProjectTransformation])
}, [activeEntity, addBoardTransformation, addProjectTransformation, useDropdownSelector])

return (
<div className='workflow-step workflow-step-add-transformation' data-step={activeStep?.id}>
Expand Down Expand Up @@ -380,6 +383,14 @@ const DataTransformations = (props) => {
onClick={() => onSave()}
// disabled={[Providers.GITLAB].includes(configuredConnection?.provider)}
style={{ marginLeft: '5px' }}
icon={(
<Tooltip
position={Position.TOP}
intent={Intent.PRIMARY}
content={'Close Editor to Continue'}>
<Spinner size={12} />
</Tooltip>
)}
/>
)}
</div>
Expand Down