feat: change duration from text to float8 - #2993
Merged
Merged
Conversation
Contributor
|
Looks good, did you test it on pg? |
Contributor
Author
Yes. job E2E test could not pass in PG, but it can pass after changing. Migrate can also run on PG. |
warren830
added a commit
to merico-ai/lake
that referenced
this pull request
Sep 9, 2022
warren830
added a commit
to merico-ai/lake
that referenced
this pull request
Sep 9, 2022
warren830
added a commit
to merico-ai/lake
that referenced
this pull request
Sep 10, 2022
warren830
added a commit
to merico-ai/lake
that referenced
this pull request
Sep 10, 2022
This was referenced Jul 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
change duration from text to float8.
After this fix, job e2e test can pass in pg.
(It can not pass before this fix.)
Does this close any open issues?
Closes #2977