Skip to content

fix(db): upgrade gorm to v1.25.5#6633

Merged
klesh merged 1 commit into
apache:mainfrom
merico-ai:upgrade-gorm
Dec 15, 2023
Merged

fix(db): upgrade gorm to v1.25.5#6633
klesh merged 1 commit into
apache:mainfrom
merico-ai:upgrade-gorm

Conversation

@d4x1
Copy link
Copy Markdown
Contributor

@d4x1 d4x1 commented Dec 15, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Upgrade gorm to v1.25.5, try to fix potential panic, more detail: panic: runtime error: invalid memory address or nil pointer dereference go-gorm/gorm#6397
  2. Return directly when getDbConnection failed

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.
The panic log looks like:
image

@d4x1 d4x1 added this to the v0.21 milestone Dec 15, 2023
@d4x1 d4x1 requested review from abeizn and klesh December 15, 2023 02:07
@d4x1 d4x1 self-assigned this Dec 15, 2023
@klesh klesh merged commit 071806c into apache:main Dec 15, 2023
@d4x1 d4x1 added the cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. needs-cherrypick-v0.20 pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants