fix(zentao): fix panic when checking db connections#6649
Merged
Conversation
klesh
reviewed
Dec 18, 2023
| go func() { | ||
| defer func() { | ||
| if err := recover(); err != nil { | ||
| result <- errors.Default.New("panic when checking database connections") |
Contributor
There was a problem hiding this comment.
please pass down the err or the information will be lost
abeizn
approved these changes
Dec 18, 2023
d4x1
added
the
cherrypick-completed
d4x1
added a commit
that referenced
this pull request
Dec 18, 2023
… to v0.20.0 (#6653) * fix(zentao): fix panic when checking db connections * fix(zentao): return panic error info directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Revert #6633， Fix panic in another way.
Does this close any open issues?
Closes N/A
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.