Skip to content

[Bug] [API] The workflow definition and the tenant in the workflow instance are inconsistent. - #12438

Closed
hstdream wants to merge 5 commits into
apache:devfrom
hstdream:buyizhi
Closed

[Bug] [API] The workflow definition and the tenant in the workflow instance are inconsistent.#12438
hstdream wants to merge 5 commits into
apache:devfrom
hstdream:buyizhi

Conversation

@hstdream

@hstdream hstdream commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Purpose of the pull request

close #12429

Brief change log

Fix the workflow definition and the tenant in the workflow instance are inconsistent.

Verify this pull request

1.create workflow definition
2.run workflow definition
3.click edit workflow
4.click edit wotkflow instance

@hstdream hstdream closed this Oct 20, 2022
@hstdream hstdream reopened this Oct 20, 2022
@codecov-commenter

codecov-commenter commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.63%. Comparing base (f0a34cd) to head (13c1ac9).
⚠️ Report is 1579 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #12438      +/-   ##
============================================
+ Coverage     39.38%   39.63%   +0.24%     
+ Complexity     4215     4194      -21     
============================================
  Files          1040     1038       -2     
  Lines         39158    38852     -306     
  Branches       4482     4450      -32     
============================================
- Hits          15424    15399      -25     
+ Misses        21958    21713     -245     
+ Partials       1776     1740      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EricGao888 EricGao888 added this to the 3.1.1 milestone Oct 20, 2022
@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly bug Something isn't working and removed improvement make more easy to user or prompt friendly labels Oct 20, 2022
@hstdream hstdream closed this Oct 21, 2022
@hstdream hstdream reopened this Oct 21, 2022
select
<include refid="baseSql"/>
from t_ds_process_definition
select pd.id, pd.code, pd.name, pd.version, pd.release_state, pd.project_code, pd.user_id, pd.description,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change this sql, you need to inject the tenant in upstream.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't it be changed?

@hstdream hstdream closed this Oct 25, 2022
@hstdream hstdream reopened this Oct 25, 2022
@hstdream hstdream closed this Oct 25, 2022
@hstdream hstdream reopened this Oct 25, 2022
@hstdream

Copy link
Copy Markdown
Contributor Author

invalid pr.

@hstdream hstdream closed this Oct 25, 2022
@hstdream hstdream reopened this Oct 25, 2022
@hstdream hstdream closed this Oct 25, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhuangchong zhuangchong removed this from the 3.1.1 milestone Oct 26, 2022
@zhuangchong zhuangchong removed the 3.1.x label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] The workflow definition and the tenant in the workflow instance are inconsistent

5 participants