[Improvement][Task] DataX Node doesn't Support Clickhouse as datasource (#5180)#5243
Merged
wen-hemin merged 4 commits intoapache:devfrom Apr 14, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5243 +/- ##
============================================
+ Coverage 47.42% 47.98% +0.56%
- Complexity 3750 3785 +35
============================================
Files 570 570
Lines 24116 24121 +5
Branches 2806 2807 +1
============================================
+ Hits 11437 11575 +138
+ Misses 11616 11462 -154
- Partials 1063 1084 +21 Continue to review full report at Codecov.
|
50a849e to
8864e17
Compare
8864e17 to
85737c5
Compare
Member
|
please add ut verify |
Member
|
@ruanwenjun Could you Improve the |
|
Kudos, SonarCloud Quality Gate passed! |
wen-hemin
requested changes
Apr 14, 2021
...ler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/datax/DataxTask.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This closes #5180, closes #5241