Skip to content

[Improvement][Task] DataX Node doesn't Support Clickhouse as datasource (#5180)#5243

Merged
wen-hemin merged 4 commits intoapache:devfrom
ruanwenjun:dev_datax_clickhouse
Apr 14, 2021
Merged

[Improvement][Task] DataX Node doesn't Support Clickhouse as datasource (#5180)#5243
wen-hemin merged 4 commits intoapache:devfrom
ruanwenjun:dev_datax_clickhouse

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 10, 2021

Purpose of the pull request

This closes #5180, closes #5241

@ruanwenjun ruanwenjun changed the title [Improvement][Module Name] DataX Node doesn't Support Clickhouse as datasource (#5180) [Improvement][Task] DataX Node doesn't Support Clickhouse as datasource (#5180) Apr 10, 2021
@codecov-io
Copy link

codecov-io commented Apr 10, 2021

Codecov Report

Merging #5243 (4d87454) into dev (f3195fc) will increase coverage by 0.56%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #5243      +/-   ##
============================================
+ Coverage     47.42%   47.98%   +0.56%     
- Complexity     3750     3785      +35     
============================================
  Files           570      570              
  Lines         24116    24121       +5     
  Branches       2806     2807       +1     
============================================
+ Hits          11437    11575     +138     
+ Misses        11616    11462     -154     
- Partials       1063     1084      +21     
Impacted Files Coverage Δ Complexity Δ
...nscheduler/server/worker/task/datax/DataxTask.java 53.09% <50.00%> (+51.31%) 23.00 <0.00> (+22.00)
...ache/dolphinscheduler/server/utils/DataxUtils.java 87.17% <100.00%> (+0.69%) 24.00 <0.00> (+2.00)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) 3.00% <0.00%> (-1.00%)
...inscheduler/service/zk/CuratorZookeeperClient.java 70.73% <0.00%> (-4.88%) 9.00% <0.00%> (-1.00%)
...er/master/processor/queue/TaskResponseService.java 67.12% <0.00%> (-4.11%) 8.00% <0.00%> (ø%)
...dolphinscheduler/service/zk/ZookeeperOperator.java 36.27% <0.00%> (-3.93%) 14.00% <0.00%> (-2.00%)
...er/server/worker/task/AbstractCommandExecutor.java 21.46% <0.00%> (-0.46%) 14.00% <0.00%> (-1.00%)
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø) 25.00% <0.00%> (ø%)
...dolphinscheduler/server/worker/task/TaskProps.java 26.82% <0.00%> (+26.82%) 13.00% <0.00%> (+13.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3195fc...4d87454. Read the comment docs.

@ruanwenjun ruanwenjun force-pushed the dev_datax_clickhouse branch from 50a849e to 8864e17 Compare April 10, 2021 03:49
@ruanwenjun ruanwenjun force-pushed the dev_datax_clickhouse branch from 8864e17 to 85737c5 Compare April 10, 2021 04:33
@CalvinKirs
Copy link
Member

please add ut verify

@chengshiwen
Copy link
Member

@ruanwenjun Could you Improve the Coverage on New Code to 33.3% at least? Thanks so much!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@break60 break60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front end +1

Copy link
Contributor

@wen-hemin wen-hemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanwenjun reviewed

Copy link
Contributor

@wen-hemin wen-hemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wen-hemin wen-hemin merged commit cc7a444 into apache:dev Apr 14, 2021
@ruanwenjun ruanwenjun deleted the dev_datax_clickhouse branch April 24, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: create dataX job json error [Improvement][Module Name] DataX Node doesn't Support Clickhouse as the datasource

6 participants