Skip to content

[Improvement][Task] Datax task add sap hana datasource#5472

Closed
dik111 wants to merge 4 commits intoapache:devfrom
dik111:dev
Closed

[Improvement][Task] Datax task add sap hana datasource#5472
dik111 wants to merge 4 commits intoapache:devfrom
dik111:dev

Conversation

@dik111
Copy link

@dik111 dik111 commented May 14, 2021

Purpose of the pull request

Datax performs ETL operations on the SAP Hana database through RDBMS
closes #5086

@CalvinKirs CalvinKirs added first time contributor First-time contributor feature new feature labels May 18, 2021
@CalvinKirs
Copy link
Member

hi, thanks for your contribution,code style check fail,you can refer this doc:https://dolphinscheduler.apache.org/zh-cn/community/development/pull-request.html

@CalvinKirs
Copy link
Member

https://mvnrepository.com/artifact/com.sap.cloud.db.jdbc/ngdbc
His license seems to be unavailable for Apache

@CalvinKirs CalvinKirs added the discussion discussion label May 18, 2021
@dik111 dik111 closed this May 18, 2021
@dik111 dik111 reopened this May 18, 2021
@dik111
Copy link
Author

dik111 commented May 18, 2021

https://mvnrepository.com/artifact/com.sap.cloud.db.jdbc/ngdbc
His license seems to be unavailable for Apache

What should i do for ngdbc dependency unavailable for Apache?

@CalvinKirs
Copy link
Member

https://mvnrepository.com/artifact/com.sap.cloud.db.jdbc/ngdbc
His license seems to be unavailable for Apache

What should i do for ngdbc dependency unavailable for Apache?

Are there other options?

@dik111
Copy link
Author

dik111 commented May 18, 2021

https://mvnrepository.com/artifact/com.sap.cloud.db.jdbc/ngdbc
His license seems to be unavailable for Apache

What should i do for ngdbc dependency unavailable for Apache?

Are there other options?

i can not find other dependency except ngdbc....

@CalvinKirs CalvinKirs removed the feature new feature label May 18, 2021
@CalvinKirs
Copy link
Member

License is indeed a troublesome issue. BTW, when you submit a PR, it is best to thoroughly discuss it first, so as to avoid this happening. I will close it. If you have a new solution, please discuss in the issue. Thanks again for your contribution.

@CalvinKirs CalvinKirs closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion discussion first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants