Skip to content

[Feature][SPI] Task - #5996

Merged
CalvinKirs merged 47 commits into
apache:task-pluginfrom
zhuangchong:task_plugin_design
Aug 18, 2021
Merged

[Feature][SPI] Task#5996
CalvinKirs merged 47 commits into
apache:task-pluginfrom
zhuangchong:task_plugin_design

Conversation

@zhuangchong

Copy link
Copy Markdown
Contributor

Purpose of the pull request

this issue #4878

this close pr #5051

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

CalvinKirs and others added 30 commits February 25, 2021 11:52
# Conflicts:
#	dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/utils/CheckUtilsTest.java
#	dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/spark/SparkParameters.java
#	dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/flink/FlinkTask.java
#	dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/mr/MapReduceTask.java
@codecov-commenter

codecov-commenter commented Aug 17, 2021

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 20.29851% with 267 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (f7e0e9f) to head (a95d2d3).

Files with missing lines Patch % Lines
.../apache/dolphinscheduler/spi/task/TaskRequest.java 0.00% 91 Missing ⚠️
...apache/dolphinscheduler/spi/task/AbstractTask.java 0.00% 39 Missing ⚠️
...che/dolphinscheduler/spi/task/ExecutionStatus.java 0.00% 37 Missing ⚠️
...eduler/server/worker/plugin/TaskPluginManager.java 0.00% 33 Missing ⚠️
...org/apache/dolphinscheduler/spi/task/Property.java 0.00% 29 Missing ⚠️
.../dolphinscheduler/spi/task/AbstractParameters.java 0.00% 11 Missing ⚠️
...apache/dolphinscheduler/spi/task/ResourceInfo.java 0.00% 10 Missing ⚠️
...olphinscheduler/service/quartz/cron/CronUtils.java 87.69% 5 Missing and 3 partials ⚠️
...ache/dolphinscheduler/common/enums/PluginType.java 0.00% 2 Missing ⚠️
...a/org/apache/dolphinscheduler/spi/task/Direct.java 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                Coverage Diff                @@
##             task-plugin    #5996      +/-   ##
=================================================
- Coverage          46.75%   46.30%   -0.45%     
- Complexity          3743     3745       +2     
=================================================
  Files                604      613       +9     
  Lines              24820    25088     +268     
  Branches            2832     2843      +11     
=================================================
+ Hits               11605    11618      +13     
- Misses             12074    12328     +254     
- Partials            1141     1142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

2.7% 2.7% Coverage
27.8% 27.8% Duplication

@CalvinKirs CalvinKirs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants