Skip to content

[Fix-6248] [API] fix processDefinnition release/processInstance update/taskDefinition transaction#6288

Merged
lenboo merged 7 commits intoapache:devfrom
brave-lee:dev_d
Sep 22, 2021
Merged

[Fix-6248] [API] fix processDefinnition release/processInstance update/taskDefinition transaction#6288
lenboo merged 7 commits intoapache:devfrom
brave-lee:dev_d

Conversation

@brave-lee
Copy link
Contributor

close #6284
fix processDefinnition release/processInstance update/taskDefinition transaction

@codecov-commenter
Copy link

Codecov Report

Merging #6288 (28ad3ec) into dev (2227751) will increase coverage by 0.07%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6288      +/-   ##
============================================
+ Coverage     38.73%   38.80%   +0.07%     
- Complexity     3210     3216       +6     
============================================
  Files           637      637              
  Lines         25360    25371      +11     
  Branches       2755     2758       +3     
============================================
+ Hits           9823     9846      +23     
+ Misses        14647    14632      -15     
- Partials        890      893       +3     
Impacted Files Coverage Δ
...er/api/controller/ProcessDefinitionController.java 55.71% <ø> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 33.16% <0.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 35.66% <9.09%> (-0.31%) ⬇️
...r/api/service/impl/ProcessInstanceServiceImpl.java 67.17% <40.00%> (+0.51%) ⬆️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 55.29% <0.00%> (+15.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2227751...28ad3ec. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

34.0% 34.0% Coverage
0.1% 0.1% Duplication

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit d716087 into apache:dev Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] Api transaction does not take effect

3 participants