Skip to content

[Fix-6302] [API] Add a new task to an existing workflow, and the task is lost#6307

Merged
lenboo merged 10 commits intoapache:devfrom
brave-lee:dev_d
Sep 23, 2021
Merged

[Fix-6302] [API] Add a new task to an existing workflow, and the task is lost#6307
lenboo merged 10 commits intoapache:devfrom
brave-lee:dev_d

Conversation

@brave-lee
Copy link
Copy Markdown
Contributor

close #6302
Add a new task to an existing workflow, and the task is lost

@brave-lee brave-lee requested a review from lenboo September 23, 2021 06:15
lenboo
lenboo previously approved these changes Sep 23, 2021
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #6307 (698f916) into dev (9115062) will increase coverage by 0.20%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6307      +/-   ##
============================================
+ Coverage     38.76%   38.96%   +0.20%     
- Complexity     3214     3223       +9     
============================================
  Files           637      637              
  Lines         25376    25376              
  Branches       2759     2760       +1     
============================================
+ Hits           9837     9888      +51     
+ Misses        14645    14583      -62     
- Partials        894      905      +11     
Impacted Files Coverage Δ
...lphinscheduler/service/process/ProcessService.java 37.43% <85.71%> (+3.56%) ⬆️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 39.00% <0.00%> (-5.68%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...rver/master/processor/queue/TaskResponseEvent.java 100.00% <0.00%> (+6.45%) ⬆️
...er/master/processor/queue/TaskResponseService.java 55.29% <0.00%> (+15.29%) ⬆️
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9115062...698f916. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor Author

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 0b53ade into apache:dev Sep 23, 2021
@brave-lee brave-lee deleted the dev_d branch October 4, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] Add a new task to an existing workflow, and the task is lost

3 participants