Fix datasource not work in tests and standalone server, and run all tests by default#6743
Merged
CalvinKirs merged 1 commit intoapache:devfrom Nov 9, 2021
kezhenxu94:datasource
Merged
Fix datasource not work in tests and standalone server, and run all tests by default#6743CalvinKirs merged 1 commit intoapache:devfrom kezhenxu94:datasource
CalvinKirs merged 1 commit intoapache:devfrom
kezhenxu94:datasource
Conversation
kezhenxu94
commented
Nov 8, 2021
...er-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/SpringConnectionFactory.java
Show resolved
Hide resolved
Member
Author
|
@CalvinKirs @ruanwenjun @lenboo this is good to review, let's merge this if it look good to you as there might be other pull requests that will conflict with this |
Member
Author
@CalvinKirs I just rebased to resolve conflicts |
ruanwenjun
reviewed
Nov 9, 2021
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
good job |
lenboo
pushed a commit
that referenced
this pull request
Nov 30, 2021
* data source spi * Fix datasource not work in tests and standalone server, and run all tests by default (#6743) * Refactor alert plugins and simplify its usage (#6723) * [Fix-6792] resolve API and alert port conflicts (#6792) (#6815) * [Fix-6792]Multiple ApplicationRunners on classpath make SpringApplication.run only run one (#6792) * [Feature][datasource] Change DataSource Connection Pool from Druid to HiKariCP (#6490) (#6828) * [Feature][datasource] Change DataSource Connection Pool from Druid to HiKariCP (#6490) * fix pom dep scope * filter alert * filter alert * filter alert * fix checkstyle * remove hikaricp version * update pom * add properties * add properties * rename properties * fix e2e fail * rename properties * [Fix-6792] resolve API and alert port conflicts (#6792) (#6815) [Fix-6792]Multiple ApplicationRunners on classpath make SpringApplication.run only run one (#6792) * fix ut fail * fix license * fix license * update package * update package * remove unused license Co-authored-by: mask <39329477+narcasserun@users.noreply.github.com> Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ruanwenjun @CalvinKirs please take a look