Refactor alert plugins and simplify its usage#6723
Merged
CalvinKirs merged 1 commit intoapache:devfrom Nov 9, 2021
kezhenxu94:plugin-refactor/alert
Merged
Refactor alert plugins and simplify its usage#6723CalvinKirs merged 1 commit intoapache:devfrom kezhenxu94:plugin-refactor/alert
CalvinKirs merged 1 commit intoapache:devfrom
kezhenxu94:plugin-refactor/alert
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6723 +/- ##
============================================
+ Coverage 41.35% 41.41% +0.06%
+ Complexity 3602 3595 -7
============================================
Files 638 625 -13
Lines 26176 26103 -73
Branches 2834 2847 +13
============================================
- Hits 10824 10810 -14
+ Misses 14370 14315 -55
+ Partials 982 978 -4
Continue to review full report at Codecov.
|
Member
Author
|
@CalvinKirs @dailidong @lenboo this can be reviewed now |
davidzollo
reviewed
Nov 8, 2021
...alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
Hey @ruanwenjun , wanna take a look at this? |
lenboo
pushed a commit
that referenced
this pull request
Nov 30, 2021
* data source spi * Fix datasource not work in tests and standalone server, and run all tests by default (#6743) * Refactor alert plugins and simplify its usage (#6723) * [Fix-6792] resolve API and alert port conflicts (#6792) (#6815) * [Fix-6792]Multiple ApplicationRunners on classpath make SpringApplication.run only run one (#6792) * [Feature][datasource] Change DataSource Connection Pool from Druid to HiKariCP (#6490) (#6828) * [Feature][datasource] Change DataSource Connection Pool from Druid to HiKariCP (#6490) * fix pom dep scope * filter alert * filter alert * filter alert * fix checkstyle * remove hikaricp version * update pom * add properties * add properties * rename properties * fix e2e fail * rename properties * [Fix-6792] resolve API and alert port conflicts (#6792) (#6815) [Fix-6792]Multiple ApplicationRunners on classpath make SpringApplication.run only run one (#6792) * fix ut fail * fix license * fix license * update package * update package * remove unused license Co-authored-by: mask <39329477+narcasserun@users.noreply.github.com> Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #6712 and should be merged after #6712
@CalvinKirs @dailidong @lenboo please take a look, this greatly simplifies how to develop a new plugin and how to use the plugins, and running locally.