Skip to content

[DS-6931][fix] swagger failed to start due to improper use of request param annotation#6933

Merged
brave-lee merged 1 commit intoapache:devfrom
eye-gu:Fix-6931
Nov 19, 2021
Merged

[DS-6931][fix] swagger failed to start due to improper use of request param annotation#6933
brave-lee merged 1 commit intoapache:devfrom
eye-gu:Fix-6931

Conversation

@eye-gu
Copy link
Contributor

@eye-gu eye-gu commented Nov 19, 2021

Purpose of the pull request

swagger failed to start due to improper use of request param annotation

Brief change log

  • ExecutorController
  • ProcessTaskRelationController

Verify this pull request

This pull request is code cleanup without any test coverage.

@codecov-commenter
Copy link

Codecov Report

Merging #6933 (e09af7e) into dev (4bec792) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6933      +/-   ##
============================================
+ Coverage     33.01%   33.06%   +0.04%     
- Complexity     1624     1626       +2     
============================================
  Files           433      433              
  Lines         14362    14362              
  Branches       1437     1437              
============================================
+ Hits           4742     4749       +7     
+ Misses         9168     9158      -10     
- Partials        452      455       +3     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (ø)
...he/dolphinscheduler/common/enums/SqoopJobType.java 88.88% <0.00%> (+88.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bec792...e09af7e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eye-gu
Copy link
Contributor Author

eye-gu commented Nov 19, 2021

#6931

Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee brave-lee merged commit 1fdbc32 into apache:dev Nov 19, 2021
@eye-gu
Copy link
Contributor Author

eye-gu commented Nov 22, 2021

#6772

brave-lee pushed a commit to brave-lee/dolphinscheduler that referenced this pull request Dec 2, 2021
… param annotation (apache#6933)

Co-authored-by: eye <eye.gu@aloudata.com>
lenboo pushed a commit that referenced this pull request Dec 3, 2021
* pick-6863

* [Improvement][API][num-7] add task delete check (#6887)

* upgrade add sub_process

* add interface method

* add interface method

* fix ut

* add task delete check

* add task delete check

* [Improvement][API][num-5] The workflow of the main table version is not allowed to be deleted (#6893)

* feature:deleteProcessDefinitionVersion

* pref:delete duplicate enum definition

Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>

* [DS-6931][fix] swagger failed to start due to improper use of request param annotation (#6933)

Co-authored-by: eye <eye.gu@aloudata.com>

* [fix #6878]  implement interface queryUpstreamRelation queryDownstreamRelation and add UT (#6888)

* fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT

* fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT

* fix: #6878, add license

* fix: #6878, code style

* fix: #6878, code style

* fix: #6878, fix Duplication

* fix: #6878

* fix: #6878 , fix style

* to #6878: fix style

* to #6878: fix style

* to #6878: add buildTaskDefinition to overwrite equals and hashCode

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>

* [Improvement][API][num-6] TaskDefinition  releaseTaskDefinition (#6965)

* finished releaseTaskDefinition

* add releaseTaskDefinition unit test

* change import

* add import

* bug fix

* change import

Co-authored-by: 时光 <caizhedong@cai-inc.com>

* pick-6966

* update task_definition_log field typ (#6967)

* update task_definition_log field typ

update task_definition_log  field task_params type,modify text to longtext to be consistent with the main table

* update t_ds_task_definition_log field task_params

update t_ds_task_definition_log field task_params

* pick-6970

* pick-6977

* pick-6984

* add processDefinition releaseWorkflowAndSchedule (#7044)

* [Improvement][API][num-1] save schedule when workflow is offline in interface 'createEmptyProcessDefinition' (#7047)

* [Improvement] save schedule when workflow is offline

* [Improvement] rollback transactional when creating/updating schedule failed.

* [Improvement] resolve merge conflict

* [Improvement] do not set projectName and processDefinitionName when saving schedule

* [Improvement] do not set projectName and processDefinitionName when saving schedule

Co-authored-by: edward-yang <yangjianh210@gmail.com>

* pick-7053

* pick-7098

* pick add 6772 relation code

* fix ut

Co-authored-by: Jeff Zhan <360400325@qq.com>
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: ououtt <734164350@qq.com>
Co-authored-by: eye <eye.gu@aloudata.com>
Co-authored-by: zwZjut <zw15068835817@163.com>
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
Co-authored-by: 时光 <41109695+yikeshiguang@users.noreply.github.com>
Co-authored-by: 时光 <caizhedong@cai-inc.com>
Co-authored-by: zhang <60912722+boy-xiaozhang@users.noreply.github.com>
Co-authored-by: EdwardYang <yangjianh210@126.com>
Co-authored-by: edward-yang <yangjianh210@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants