update task_definition_log field typ#6967
Merged
brave-lee merged 2 commits intoapache:devfrom Nov 23, 2021
boy-xiaozhang:dev
Merged
update task_definition_log field typ#6967brave-lee merged 2 commits intoapache:devfrom boy-xiaozhang:dev
brave-lee merged 2 commits intoapache:devfrom
boy-xiaozhang:dev
Conversation
update task_definition_log field task_params type,modify text to longtext to be consistent with the main table
Codecov Report
@@ Coverage Diff @@
## dev #6967 +/- ##
============================================
- Coverage 32.84% 32.75% -0.10%
+ Complexity 1621 1618 -3
============================================
Files 432 432
Lines 14379 14379
Branches 1446 1446
============================================
- Hits 4723 4710 -13
- Misses 9202 9214 +12
- Partials 454 455 +1
Continue to review full report at Codecov.
|
brave-lee
reviewed
Nov 23, 2021
| `user_id` int(11) DEFAULT NULL COMMENT 'task definition creator id', | ||
| `task_type` varchar(50) NOT NULL COMMENT 'task type', | ||
| `task_params` text COMMENT 'job custom parameters', | ||
| `task_params` longtext COMMENT 'job custom parameters', |
Contributor
There was a problem hiding this comment.
Please also modify the dolphinscheduler_mysql.sql
Contributor
Author
There was a problem hiding this comment.
Ok, it has been modified
update t_ds_task_definition_log field task_params
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
attached #6772 |
brave-lee
pushed a commit
to brave-lee/dolphinscheduler
that referenced
this pull request
Dec 2, 2021
* update task_definition_log field typ update task_definition_log field task_params type,modify text to longtext to be consistent with the main table * update t_ds_task_definition_log field task_params update t_ds_task_definition_log field task_params
lenboo
pushed a commit
that referenced
this pull request
Dec 3, 2021
* pick-6863 * [Improvement][API][num-7] add task delete check (#6887) * upgrade add sub_process * add interface method * add interface method * fix ut * add task delete check * add task delete check * [Improvement][API][num-5] The workflow of the main table version is not allowed to be deleted (#6893) * feature:deleteProcessDefinitionVersion * pref:delete duplicate enum definition Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> * [DS-6931][fix] swagger failed to start due to improper use of request param annotation (#6933) Co-authored-by: eye <eye.gu@aloudata.com> * [fix #6878] implement interface queryUpstreamRelation queryDownstreamRelation and add UT (#6888) * fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: #6878, add license * fix: #6878, code style * fix: #6878, code style * fix: #6878, fix Duplication * fix: #6878 * fix: #6878 , fix style * to #6878: fix style * to #6878: fix style * to #6878: add buildTaskDefinition to overwrite equals and hashCode Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com> * [Improvement][API][num-6] TaskDefinition releaseTaskDefinition (#6965) * finished releaseTaskDefinition * add releaseTaskDefinition unit test * change import * add import * bug fix * change import Co-authored-by: 时光 <caizhedong@cai-inc.com> * pick-6966 * update task_definition_log field typ (#6967) * update task_definition_log field typ update task_definition_log field task_params type,modify text to longtext to be consistent with the main table * update t_ds_task_definition_log field task_params update t_ds_task_definition_log field task_params * pick-6970 * pick-6977 * pick-6984 * add processDefinition releaseWorkflowAndSchedule (#7044) * [Improvement][API][num-1] save schedule when workflow is offline in interface 'createEmptyProcessDefinition' (#7047) * [Improvement] save schedule when workflow is offline * [Improvement] rollback transactional when creating/updating schedule failed. * [Improvement] resolve merge conflict * [Improvement] do not set projectName and processDefinitionName when saving schedule * [Improvement] do not set projectName and processDefinitionName when saving schedule Co-authored-by: edward-yang <yangjianh210@gmail.com> * pick-7053 * pick-7098 * pick add 6772 relation code * fix ut Co-authored-by: Jeff Zhan <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: ououtt <734164350@qq.com> Co-authored-by: eye <eye.gu@aloudata.com> Co-authored-by: zwZjut <zw15068835817@163.com> Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com> Co-authored-by: 时光 <41109695+yikeshiguang@users.noreply.github.com> Co-authored-by: 时光 <caizhedong@cai-inc.com> Co-authored-by: zhang <60912722+boy-xiaozhang@users.noreply.github.com> Co-authored-by: EdwardYang <yangjianh210@126.com> Co-authored-by: edward-yang <yangjianh210@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the 2.0.0 release, it was found that the field types were inconsistent, causing the process_json upgrade to fail,update task_definition_log field task_params type,modify text to longtext to be consistent with the main table