Skip to content

[Fix-7767]Task instance is not deleted while deleting the process instance#7768

Merged
caishunfeng merged 5 commits intoapache:devfrom
SbloodyS:bug_7767
Jan 3, 2022
Merged

[Fix-7767]Task instance is not deleted while deleting the process instance#7768
caishunfeng merged 5 commits intoapache:devfrom
SbloodyS:bug_7767

Conversation

@SbloodyS
Copy link
Copy Markdown
Member

@SbloodyS SbloodyS commented Jan 1, 2022

Purpose of the pull request

close #7767

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 1, 2022

Codecov Report

Merging #7768 (8777507) into dev (fa906e7) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7768      +/-   ##
============================================
- Coverage     40.95%   40.83%   -0.13%     
+ Complexity     3671     3666       -5     
============================================
  Files           642      642              
  Lines         26707    26740      +33     
  Branches       2997     3006       +9     
============================================
- Hits          10939    10920      -19     
- Misses        14716    14771      +55     
+ Partials       1052     1049       -3     
Impacted Files Coverage Δ
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.56% <0.00%> (-0.18%) ⬇️
...lphinscheduler/service/process/ProcessService.java 35.31% <0.00%> (-0.28%) ⬇️
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-8.04%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-0.71%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 25.70% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa906e7...8777507. Read the comment docs.

@SbloodyS
Copy link
Copy Markdown
Member Author

SbloodyS commented Jan 2, 2022

@caishunfeng please review again.thx.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 7395b98 into apache:dev Jan 3, 2022
@SbloodyS SbloodyS deleted the bug_7767 branch January 3, 2022 08:10
SbloodyS added a commit to SbloodyS/dolphinscheduler that referenced this pull request Jan 7, 2022
…tance (apache#7768)

* fix bug_7767

* fix bug_7767

* fix bug_7767

* fix bug_7767

* fix bug_7767
caishunfeng pushed a commit that referenced this pull request Jan 9, 2022
* cherry-pick

* fix bug_7629 (#7630)

* fix bug_7564 (#7625)

* fix bug_7512 (#7716)

* [Fix-7459][Sqoop] running error in parallel (#7752)

* fix bug_7459

* fix bug_7459

* fix bug_7459

* fix bug_7459

* fix bug_7459

Co-authored-by: SbloodyS <sbloodys@qq.com>

* [Feature-7576][Master] Optimize complement task's date (#7585)

* feature_7576

* feature_7576

* feature 7576

* feature 7576

* [Fix-7767]Task instance is not deleted while deleting the process instance (#7768)

* fix bug_7767

* fix bug_7767

* fix bug_7767

* fix bug_7767

* fix bug_7767

* [Feature-5951][Improvement][UI] When creating an alarm instance, the alarm instance name input box prompts optimization (#7770)

* cherry-pick

* [Fix-7773][Api] malform batchDeleteProcessInstanceByIds log output (#7774)

* bug_7773

* bug_7773

* bug_7773

* bug_7773

* bug_7773

* [Feature-7777][UI] process definition page add create username (#7778)

* feature_7777

* fix bug_7499 (#7739)

Co-authored-by: SbloodyS <sbloodys@qq.com>

* fix conflict

* fix conflict

* fix mapState never used error

* fix bug_7789 (#7790)

Co-authored-by: SbloodyS <sbloodys@qq.com>

Co-authored-by: SbloodyS <sbloodys@qq.com>
Co-authored-by: wangyizhi <wangyizhi1_yewu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete the log of ‘workflow instance’ The log of ‘task instance’ is not deleted in cascade

3 participants