[Fix-7773][Api] malform batchDeleteProcessInstanceByIds log output#7774
Merged
caishunfeng merged 5 commits intoapache:devfrom Jan 4, 2022
Merged
[Fix-7773][Api] malform batchDeleteProcessInstanceByIds log output#7774caishunfeng merged 5 commits intoapache:devfrom
caishunfeng merged 5 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7774 +/- ##
============================================
- Coverage 40.95% 40.85% -0.11%
+ Complexity 3671 3666 -5
============================================
Files 642 642
Lines 26707 26730 +23
Branches 2997 3004 +7
============================================
- Hits 10939 10920 -19
- Misses 14716 14761 +45
+ Partials 1052 1049 -3
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
reviewed
Jan 4, 2022
| ProcessInstance processInstance = processService.findProcessInstanceDetailById(processInstanceId); | ||
| if (null == processInstance) { | ||
| putMsg(result, Status.PROCESS_INSTANCE_NOT_EXIST, processInstanceId); | ||
| putMsg(result, Status.PROCESS_INSTANCE_NOT_EXIST, String.valueOf(processInstanceId)); |
Contributor
There was a problem hiding this comment.
What's the different of log?
Member
Author
There was a problem hiding this comment.
eg:
The input processInstanceId is 1234.
Before: 工 作 流 实 例 [1,234]不 存 在
After: 工 作 流 实 例 [1234]不 存 在
Status.PROCESS_INSTANCE_NOT_EXIST using {0} as parameter while input type in integer may cause this problem.
SbloodyS
added a commit
to SbloodyS/dolphinscheduler
that referenced
this pull request
Jan 7, 2022
…pache#7774) * bug_7773 * bug_7773 * bug_7773 * bug_7773 * bug_7773
caishunfeng
pushed a commit
that referenced
this pull request
Jan 9, 2022
* cherry-pick * fix bug_7629 (#7630) * fix bug_7564 (#7625) * fix bug_7512 (#7716) * [Fix-7459][Sqoop] running error in parallel (#7752) * fix bug_7459 * fix bug_7459 * fix bug_7459 * fix bug_7459 * fix bug_7459 Co-authored-by: SbloodyS <sbloodys@qq.com> * [Feature-7576][Master] Optimize complement task's date (#7585) * feature_7576 * feature_7576 * feature 7576 * feature 7576 * [Fix-7767]Task instance is not deleted while deleting the process instance (#7768) * fix bug_7767 * fix bug_7767 * fix bug_7767 * fix bug_7767 * fix bug_7767 * [Feature-5951][Improvement][UI] When creating an alarm instance, the alarm instance name input box prompts optimization (#7770) * cherry-pick * [Fix-7773][Api] malform batchDeleteProcessInstanceByIds log output (#7774) * bug_7773 * bug_7773 * bug_7773 * bug_7773 * bug_7773 * [Feature-7777][UI] process definition page add create username (#7778) * feature_7777 * fix bug_7499 (#7739) Co-authored-by: SbloodyS <sbloodys@qq.com> * fix conflict * fix conflict * fix mapState never used error * fix bug_7789 (#7790) Co-authored-by: SbloodyS <sbloodys@qq.com> Co-authored-by: SbloodyS <sbloodys@qq.com> Co-authored-by: wangyizhi <wangyizhi1_yewu@cmss.chinamobile.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pr will close #7773