Skip to content

[ci] Remove e2e workflow paths-ignore attribute#7807

Merged
zhuangchong merged 1 commit intoapache:devfrom
zhongjiajie:ci-rm-ignore
Jan 5, 2022
Merged

[ci] Remove e2e workflow paths-ignore attribute#7807
zhuangchong merged 1 commit intoapache:devfrom
zhongjiajie:ci-rm-ignore

Conversation

@zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Jan 5, 2022

It will cause our CI always waitting due to
we requests E2E contexts in .asf.yaml but
we set some ignore path on workflow e2e.

ref: #7695, #7612

It will cause our CI always waitting due to
we requests E2E contexts in .asf.yaml but
we set some ignore path on workflow e2e.
@zhongjiajie zhongjiajie added minor Chore Chores about the project, like code clean, typo, etc. CI&CD labels Jan 5, 2022
@zhongjiajie zhongjiajie self-assigned this Jan 5, 2022
@zhongjiajie zhongjiajie changed the title [ci] Remove workflow paths-ignore attribute [ci] Remove e2e workflow paths-ignore attribute Jan 5, 2022
@zhongjiajie
Copy link
Member Author

FYI,

we request every PR need E2E context, but we have ignore path in
pull_request:
paths-ignore:
- '**/*.md'
- 'dolphinscheduler-python/pydolphinscheduler'
push:
paths-ignore:
- '**/*.md'
- 'dolphinscheduler-python/pydolphinscheduler'
branches:
- dev
. Releted PR #7612

@codecov-commenter
Copy link

Codecov Report

Merging #7807 (82003ef) into dev (120c175) will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7807      +/-   ##
============================================
- Coverage     41.18%   40.84%   -0.34%     
  Complexity     3669     3669              
============================================
  Files           641      637       -4     
  Lines         26525    26783     +258     
  Branches       2964     3017      +53     
============================================
+ Hits          10924    10940      +16     
- Misses        14575    14792     +217     
- Partials       1026     1051      +25     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...inscheduler/server/log/LoggerRequestProcessor.java 20.31% <0.00%> (-39.07%) ⬇️
...e/dolphinscheduler/api/aspect/AccessLogAspect.java 67.24% <0.00%> (-13.72%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 26.13% <0.00%> (-5.70%) ⬇️
...heduler/api/service/impl/TaskGroupServiceImpl.java 60.17% <0.00%> (-3.83%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️
...inscheduler/server/master/config/MasterConfig.java 69.56% <0.00%> (-0.44%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-0.44%) ⬇️
...api/service/impl/ProcessDefinitionServiceImpl.java 25.70% <0.00%> (-0.34%) ⬇️
...r/server/worker/registry/WorkerRegistryClient.java 3.44% <0.00%> (-0.33%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120c175...82003ef. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit ab89e43 into apache:dev Jan 5, 2022
@zhongjiajie zhongjiajie deleted the ci-rm-ignore branch January 5, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI&CD minor Chore Chores about the project, like code clean, typo, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants