Skip to content

Correct typo in English README#7695

Merged
zhongjiajie merged 3 commits intoapache:devfrom
brnnnfx:patch-1
Jan 7, 2022
Merged

Correct typo in English README#7695
zhongjiajie merged 3 commits intoapache:devfrom
brnnnfx:patch-1

Conversation

@brnnnfx
Copy link
Contributor

@brnnnfx brnnnfx commented Dec 28, 2021

Purpose of the pull request

This corrects a minor typo to make the README file a little more clear for readers.

Brief change log

Change the following line...

Please referer the official website document...

...to appear as...

Please refer to the official website document...

Verify this pull request

This pull request is code cleanup without any test coverage.

@brnnnfx
Correct typo in English README
b7037e4 
Corrects a minor typo
@zhuangchong zhuangchong added the first time contributor First-time contributor label Jan 4, 2022
zhuangchong
zhuangchong previously approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuangchong zhuangchong added this to the 2.0.3-release milestone Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022 •
edited
Loading

Codecov Report

Merging #7695 (52b78bd) into dev (7fd94ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #7695   +/-   ##
=========================================
  Coverage     41.03%   41.03%           
  Complexity     3695     3695           
=========================================
  Files           637      637           
  Lines         27025    27025           
  Branches       3063     3063           
=========================================
  Hits          11089    11089           
  Misses        14867    14867           
  Partials       1069     1069

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd94ff...52b78bd. Read the comment docs.

@brnnnfx
Copy link
Contributor Author

brnnnfx commented Jan 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 14 Code Smells

30.8% 30.8% Coverage 0.0% 0.0% Duplication

Hi @zhuangchong , thanks for the approval. Does my change still need to be bound by this ⬆️ ?

The lacking code coverage level is in files I didn't touch / are not affected by my change.

@lenboo
Copy link
Contributor

lenboo commented Jan 5, 2022 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed
Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 14 Code Smells
30.8% 30.8% Coverage 0.0% 0.0% Duplication

Hi @zhuangchong , thanks for the approval. Does my change still need to be bound by this ⬆️ ?

The lacking code coverage level is in files I didn't touch / are not affected by my change.

hi @brnnnfx:
Thanks for your contribution. Because of changes of checklist(we added e2e checklist in last month), I'm afraid you need to rebase the latest dev branch to your branch 'patch-1'.

@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 5, 2022

I do not thinks it is related to this point. It keeps waiting cause we have a confilc setting about it. I would submit a PR to correct it

@zhongjiajie zhongjiajie mentioned this pull request Jan 5, 2022
Merged
@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 5, 2022 •
edited by zhuangchong
Loading

I do not thinks it is related to this point. It keeps waiting cause we have a confilc setting about it. I would submit a PR to correct it

I submit PR #7807 to correct our CI workflow. @brnnnfx you could rebase after PR #7807 merged

@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 5, 2022

I submit PR #7807 to correct our CI workflow. @brnnnfx you could rebase after PR #7807 merged

@brnnnfx Now you could rebase to dev and force push to restart CI

@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 6, 2022

I approval to run CI just now, we would waiting CI result

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

zhongjiajie
zhongjiajie approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit 46c39cd into apache:dev Jan 7, 2022
@zhongjiajie
Copy link
Member

zhongjiajie commented Jan 7, 2022

Hi @brnnnfx , thanks for your contribution and welcome to join the community 🎉 . If you want to contribute but could not find issues, maybe you could start in #5689 or just search our issue list https://github.com/apache/dolphinscheduler/issues. Looking forward to your next contribution.

@brnnnfx brnnnfx deleted the patch-1 branch January 7, 2022 03:54
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
@brnnnfx
[cherry-pick-2.0.3]Correct typo in English README apache#7695
6c91a0e
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 14, 2022
@brnnnfx
[cherry-pick-2.0.3]Correct typo in English README apache#7695
06a2d64
@caishunfeng caishunfeng mentioned this pull request Jan 14, 2022
Merged
zhongjiajie pushed a commit that referenced this pull request Jan 14, 2022
@caishunfeng @brnnnfx
@CalvinKirs @jxeditor @jim-parsons
[cherry-pick-2.0.3]Cherry pick to 2.0.3 (#8041)
1f0aeab 
* [cherry-pick-2.0.3]Correct typo in English README #7695

* Update NOTICE year (#7784)

* [BUG] Repair JDBC connection of Oracle (#7883)

* [cherry-pick-2.0.3][Fix-7538] [server] Fix when there is a forbidden node in dag, the execution flow is abnormal #7613

* [cherry-pick-2.0.3][Fix-7825] Remedy the value of create time and update time to be current time when importing a process json file. #7828

* [FIX-7732][fix] fix column 'is_directory' of table `t_ds_resources` type error in PG database (#7898)

Fix column 'is_directory' of table t_ds_resources type error in PG database
This closes #7732

Co-authored-by: Brennan Fox <brnnnfx@users.noreply.github.com>
Co-authored-by: Kirs <acm_master@163.com>
Co-authored-by: X&Z <980813351@qq.com>
Co-authored-by: caishunfeng <534328519@qq.com>
Co-authored-by: 天仇 <532066967@qq.com>
@caishunfeng caishunfeng added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@zhuangchong zhuangchong zhuangchong left review comments

Assignees

No one assigned

Labels

first time contributor First-time contributor release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Milestone

2.0.3-release

Development

Successfully merging this pull request may close these issues.

6 participants

@brnnnfx @codecov-commenter @lenboo @zhongjiajie @zhuangchong @caishunfeng